Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement toasts #125

Merged
merged 4 commits into from
Mar 26, 2020
Merged

Reimplement toasts #125

merged 4 commits into from
Mar 26, 2020

Conversation

ethanwu10
Copy link
Member

Reimplement toasts with a more sensible structure, using a provider component for context instead of wrapping a component, and cleaning up implementation.

Reimplement toasts with a more sensible structure, using a provider
component for context instead of wrapping a component, and cleaning up
implementation.
@ethanwu10 ethanwu10 added the refactoring Improve code quality label Mar 25, 2020
@ethanwu10 ethanwu10 added this to in-progress in Frontend via automation Mar 25, 2020
client/src/components/toast.js Show resolved Hide resolved
client/src/pages/profile.js Show resolved Hide resolved
This was referenced Mar 26, 2020
@chen-robert chen-robert merged commit 5992572 into master Mar 26, 2020
Frontend automation moved this from in-progress to done Mar 26, 2020
@chen-robert chen-robert deleted the refactor/toasts branch March 26, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Improve code quality
Projects
Frontend
  
done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants