Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update preact-cli, clean up client build #133

Merged
merged 6 commits into from
Mar 28, 2020
Merged

Update preact-cli, clean up client build #133

merged 6 commits into from
Mar 28, 2020

Commits on Mar 28, 2020

  1. refactor(client): update preact-cli 

    Update preact-cli to 3.0.0-rc.10 (the RC versions are being used by the
default template).

Also move `client/src/pages` to `client/src/routes` to enable route
splitting, move icons to within the `client/src` tree, and move contents
of `public` directory to the appropriate places within the `client/src`
tree.
    @ethanwu10
    ethanwu10 committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    0454df4 View commit details
    Browse the repository at this point in the history

  2. fix(client): update HTML template, disable prerendering 

    Update HTML template to latest from preact-cli. Also disable
prerendering, which now breaks on build (attempting to read sourcemaps).

This change injects inline scripts into the built HTML.
    @ethanwu10
    ethanwu10 committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    d71194c View commit details
    Browse the repository at this point in the history

  3. fix(client): use portals in modals 

    Since updating preact-cli fixed the import resolution issues causing
unmounting portals to crash, we can now use portals in the Modal
component.
    @ethanwu10
    ethanwu10 committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    61e5838 View commit details
    Browse the repository at this point in the history

  4. fix(client): ensure profile data is fetched on mount 

    Explicitly check to fetch data for profile page on component mount as
well as update.
    @ethanwu10
    ethanwu10 committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    1865a9b View commit details
    Browse the repository at this point in the history

  5. fix(client): avoid passing false as a ref 

    Preact will crash if `false` is passed as a ref, so ensure we pass
either a valid ref or `null`.
    @ethanwu10
    ethanwu10 committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    04057ac View commit details
    Browse the repository at this point in the history

  6. ci: remove (now nonexistant) client scripts from shellcheck job 

    We no longer have any shell scripts in client/, so don't try to
shellcheck them.
    @ethanwu10
    ethanwu10 committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    2952e89 View commit details
    Browse the repository at this point in the history