Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): split leaderboard into separate containers #305

Merged
merged 3 commits into from
May 30, 2020

Conversation

ginkoid
Copy link
Member

@ginkoid ginkoid commented May 30, 2020

No description provided.

Copy link
Member

@ethanwu10 ethanwu10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -35,7 +35,7 @@ const config = {
password: process.env.RCTF_REDIS_PASSWORD,
database: process.env.RCTF_REDIS_DATABASE
},
migrate: process.env.RCTF_DATABASE_MIGRATE || 'never'
migrate: process.env.RCTF_DATABASE_MIGRATE || 'never' // enum: never, before, only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to move these into actual enum types at some point

@chen-robert chen-robert merged commit 2db18de into master May 30, 2020
@chen-robert chen-robert deleted the feature/split-leaderboard branch May 30, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants