Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Y8S3 support #65

Merged
merged 1 commit into from
Aug 30, 2023
Merged

feat: Add Y8S3 support #65

merged 1 commit into from
Aug 30, 2023

Conversation

f870103
Copy link
Contributor

@f870103 f870103 commented Aug 30, 2023 •
edited
Loading

  • Add new operator Ram
  • Change match type name from Unranked to Standard
  • Add Y8S3 version code

Known Issue

  • Output xlsx file is broken

Tested & verified with new replay files:

  • Quick Match
  • Standard
  • Ranked

@f870103
Copy link
Contributor Author

f870103 commented Aug 30, 2023

Just found that the xlsx output is broken.

Build environment:
Build on golang:latest docker image
go version go1.21.0 linux/amd64

@redraskal
Copy link
Owner

redraskal commented Aug 30, 2023 •
edited
Loading

Just found that the xlsx output is broken.

Build environment: Build on golang:latest docker image go version go1.21.0 linux/amd64

Looks like this issue will be fixed in a future Go release. For now, the Excel output will work on Go 1.20.7.

golang/go#62051

@redraskal redraskal merged commit 5e45ad8 into redraskal:main Aug 30, 2023
3 checks passed
@redraskal
Copy link
Owner

thank you for the PR! github actions will build on Go 1.20 until the xlsx issue is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redraskal redraskal redraskal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@f870103 @redraskal