Fixes #99: Add option to set file encoding to CSV reader. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redstreet
reviewed
Apr 7, 2024
awtimmering
force-pushed
the
fix99_encoding
branch
from
dba469e
to
d2cbcd7
Compare
redstreet
requested changes
Apr 7, 2024
| rdr = rdr.skip(getattr(self, "skip_head_rows", 0)) # chop unwanted header rows | ||
| rdr = rdr.skip( | ||
| getattr(self, "skip_head_rows", 0) | ||
| ) # chop unwanted header rows |
There was a problem hiding this comment.
Hmm, this line shouldn't have changed. Would you managering have the latest commits which have the right line width for ruff?
There was a problem hiding this comment.
Yes of course, sorry for that!
|
If you could also take a look at the failures above that would be great. One of them existed prior to your commit. Two of them are related to this PR. Contributing.md should show you what to do. Thanks! |
fixed support for importers on non-UTF8 (e.g. Shift-JIS) text files. Fixes redstreet#99.
awtimmering
force-pushed
the
fix99_encoding
branch
from
d2cbcd7
to
9b2e909
Compare
|
No worries, and perfect, merged, thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #99
Let me know if this seems the right approach (right place to set the attribute).
Happy to see if I can add a unit test as well.