Add handling for Git worktrees #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Thank you so much for the contribution, it works well. I've just made one change to the test - the repository needed to have a commit before a worktree could be created. |
|
Thanks for fixing the test! I saw the failure but was having trouble running the tests locally (and didn’t have time to dig in). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #21, the extension doesn't currently work with Git worktrees. This change updates the logic in RepositoryFinder to allow
.gitto be either a directory or a file (it's a file for worktrees). Provided that the directory containing.gitis only ever used as the cwd for running git commands, not for digging around in the git folder structure, this should be safe.I added one test, but please let me know if there are other specific things you'd like to see tested and where to add that.
Fixes #21.