Skip to content

Commit

Permalink
Moving the localization configuration out of a "render" method, since…
Browse files Browse the repository at this point in the history
… it's not responsability of the view layer
  • Loading branch information
andrerpena committed Jul 26, 2016
1 parent d52d993 commit 8018bb7
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 17 deletions.
13 changes: 13 additions & 0 deletions demo/Client.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,24 @@ import {Provider} from 'react-redux';
import {syncHistoryWithStore} from 'react-router-redux';
import {browserHistory} from 'react-router'
import {render} from 'react-dom';
import moment from 'moment';
import numbro from 'numbro';
import reactWidgetsMomentLocalizer from 'react-widgets/lib/localizers/moment';
import momentLocalizer from 'redux-autoform-utils/lib/localization/momentLocalizer';
import numbroLocalizer from 'redux-autoform-utils/lib/localization/numbroLocalizer';

import './less/styles.less';

const store = configureStore();
const history = syncHistoryWithStore(browserHistory, store);

// setting date localizer
reactWidgetsMomentLocalizer(moment);
momentLocalizer(moment);

// setting number localizer
numbroLocalizer(numbro);

render(
<Provider store={store}>
<Router history={history} routes={routes}/>
Expand Down
15 changes: 0 additions & 15 deletions demo/components/LiveSchemaEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,6 @@ import psjon from '../../package.json';
import { AutoForm } from 'redux-autoform';
import { EditComponentFactory, DetailsComponentFactory } from '../../src/index';
import { Alert, Badge } from 'react-bootstrap';
import moment from 'moment';
import numbro from 'numbro';
import reactWidgetsMomentLocalizer from 'react-widgets/lib/localizers/moment';
import momentLocalizer from 'redux-autoform-utils/lib/localization/momentLocalizer';
import numbroLocalizer from 'redux-autoform-utils/lib/localization/numbroLocalizer';
import ButtonToolbar from './ButtonToolbar';
import FormOptions from './FormOptions';

Expand Down Expand Up @@ -116,18 +111,8 @@ class LiveSchemaEditor extends Component {
return _.find(presets, p => p.name == preset);
};

setLocalizers = () => {
// setting date localizer
reactWidgetsMomentLocalizer(moment);
momentLocalizer(moment);

// setting number localizer
numbroLocalizer(numbro);
};

render() {
let { reduxFormActions, preset, metaForm, formOptions, formOptionsActions } = this.props;
this.setLocalizers();

return (
<div className="live-schema-editor">
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,13 @@
"npm": "^3.3.4",
"numbro": "^1.9.1",
"path": "^0.12.7",
"phantomjs": "^2.1.7",
"phantomjs-prebuilt": "^2.1.7",
"raw-loader": "^0.5.1",
"react-ace": "^3.4.1",
"react-hot-loader": "^1.3.0",
"react-router": "^2.0.0",
"react-router-redux": "^4.0.2",
"redux-autoform": "^0.8.0",
"redux-autoform": "^0.8.1",
"redux-devtools": "^3.2.0",
"redux-devtools-dock-monitor": "^1.1.1",
"redux-devtools-log-monitor": "^1.0.9",
Expand Down

0 comments on commit 8018bb7

Please sign in to comment.