Added disabled attribute in autoform field #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Child inherits disabled property from Parent. Parent’s disabled property has preference over child’s disabled property.
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 23.71% 23.76% +0.04%
==========================================
Files 36 36
Lines 683 686 +3
Branches 108 108
==========================================
+ Hits 162 163 +1
- Misses 521 523 +2
Continue to review full report at Codecov.
|
|
Great! I will merge the changes proposed! Thanks again for your contribution @nikhilarunw! |
|
@nikhilarunw are you interested to become a contributor of those projects? |
|
Yes. I am interested to contribute. |
|
@nikhilarunw I wil gave you access to the redux-autoform repos. Welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds support of disabled attribute for autoform components.
Disabled attribute can be set on Field, Entity, EntityContainer, ArrayContainer.
Child entity/field will inherit disabled attribute from parent entity if available.
Value of Parent entity for disabled value will have preference over child's disabled attribute.