Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underscore and clone libs and refactor code using native ES6 functions. #46

Closed
danigomez opened this issue Jul 22, 2016 · 3 comments
Assignees
Milestone

Comments

@danigomez
Copy link
Contributor

The following files are using functions provided by underscore and clone which can be replaced by native ES6 code.

  • metadata\evaluator\filter\arrayMetadataFilter.js
  • metadata\evaluator\filter\defaultMetadataFilter.js
  • metadata\evaluator\filter\entityMetadataFilter.js
  • metadata\evaluator\metadataEvaluator.js
  • metadata\model\modelParser.js
  • metadata\validator\metadataValidator.js
  • metadata\MetadataProvider.js

What do you think??, is there a reason to not change unsderscore to native ES6??

@andrerpena
Copy link
Member

I don't oppose to it, I just don't find it a priority. Feel free to do it 😄

@JonatanSalas
Copy link
Member

@andrerpena with this we reduce some dependencies, we use native es6 syntax and we could make the code for metadata management even more clear to read and understand.

@danigomez
Copy link
Contributor Author

Great! i will start to do this!

This was referenced Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants