Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Metadata code. #49

Closed
danigomez opened this issue Jul 25, 2016 · 5 comments
Closed

Add tests for Metadata code. #49

danigomez opened this issue Jul 25, 2016 · 5 comments
Assignees
Milestone

Comments

@danigomez
Copy link
Contributor

Hello @andrerpena , in task #46 i'm using the demo to check my changes, but it will be awesome if we can have tests for this code in order to make sure that we are not breaking anything! 馃槃

@JonatanSalas
Copy link
Member

Yes, this will be good because if we want to make some refactor or any addition to the code of the core, we don't break nothing, and we get a better coverage too.

@JonatanSalas
Copy link
Member

@andrerpena what's your opinion about this?

@andrerpena
Copy link
Member

I believe we currently only have tests for

  • metadata\validator\metadataValidator.js
  • metadata\MetadataProvider.js

I agree we should cover the rest. I'll take it.

@andrerpena andrerpena self-assigned this Jul 25, 2016
@andrerpena andrerpena added this to the v1.0.0 milestone Jul 25, 2016
@JonatanSalas
Copy link
Member

@andrerpena thank you very much!

@JonatanSalas
Copy link
Member

Since there is another issue for test coverage open, I think closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants