Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in Float Value #91

Closed
devang-kredx opened this issue Sep 15, 2016 · 9 comments
Closed

Bug in Float Value #91

devang-kredx opened this issue Sep 15, 2016 · 9 comments
Labels

Comments

@devang-kredx
Copy link
Contributor

Putting a 0 value gives "Invalid decimal"
https://redux-autoform.github.io/redux-autoform-bootstrap-ui/demo.html?preset=componentsTextBoxFloat

@JonatanSalas
Copy link
Member

I will take a look at it! Thank you!

@andrerpena
Copy link
Member

Thanks for reporting

@andrerpena andrerpena added the bug label Sep 15, 2016
@devang-kredx
Copy link
Contributor Author

@JonatanSalas Checking in to see if there is any estimate by when this bug would be resolved?

@JonatanSalas
Copy link
Member

I will take a look this weekend. Because this week I'm with a lot of work :/

@devang-kredx
Copy link
Contributor Author

Just FYI, the issue is that the following code is being triggered with 0 float value. Not sure why.
https://github.com/redux-autoform/redux-autoform-utils/blob/master/src/localization/numbroLocalizer.js#L18

@andrerpena
Copy link
Member

OMG.. Good catch. Those should be ===. I didn't analyze it further but
that's what I think at first sight. Can someone send a PR?

Em 21 de set de 2016 10:04 AM, "devang-kredx" notifications@github.com
escreveu:

Just FYI, the issue is that the following code is being triggered with 0
float value. Not sure why.
https://github.com/redux-autoform/redux-autoform-utils/
blob/master/src/localization/numbroLocalizer.js#L18


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#91 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABghdSsqWwEvtp69AFKnkCOLd-GLgXiRks5qsStAgaJpZM4J9503
.

@devang-kredx
Copy link
Contributor Author

Looks like its already fixed in autoforms-utils. Anything needs to be
changed in react-autoform to pick this fix?

On Wed, Sep 21, 2016 at 6:42 PM André Pena notifications@github.com wrote:

OMG.. Good catch. Those should be ===. I didn't analyze it further but
that's what I think at first sight. Can someone send a PR?

Em 21 de set de 2016 10:04 AM, "devang-kredx" notifications@github.com
escreveu:

Just FYI, the issue is that the following code is being triggered with 0
float value. Not sure why.
https://github.com/redux-autoform/redux-autoform-utils/
blob/master/src/localization/numbroLocalizer.js#L18


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<
#91 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/ABghdSsqWwEvtp69AFKnkCOLd-GLgXiRks5qsStAgaJpZM4J9503

.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#91 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARERBEhSA-y1mYc3Hp_-DZimXcvesguRks5qsS0ZgaJpZM4J9503
.

@andrerpena
Copy link
Member

I ended up fixing the line you pointed out. If this is not the only source of the problem, this is surely one.

We need to publish a new version of the utils, update the redux-autoform reference and republish it. I don't know if I'll be able to do it in a timely manner because I got lots of work. But I'll try as soon as I can.

@devang-kredx
Copy link
Contributor Author

Closed via #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants