feature/ValidSelectorsTypes fixes return Selectors types by types.js.…

…flow (#3634)
redux-form · Nov 23, 2017 · 24f4dff · 24f4dff
1 parent 81169ce
commit 24f4dff
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 16 deletions.
diff --git a/src/selectors/__tests__/getFormMeta.spec.js b/src/selectors/__tests__/getFormMeta.spec.js
@@ -50,7 +50,7 @@ const describeGetFormMeta = (name, structure, setup) => {
       })
     })
 
-    it('should return undefined if there are no fields', () => {
+    it('should return object if there are no fields', () => {
       expect(
         getFormMeta('foo')(
           fromJS({
@@ -59,7 +59,7 @@ const describeGetFormMeta = (name, structure, setup) => {
             }
           })
         )
-      ).toEqual(undefined)
+      ).toEqual(fromJS({}))
     })
 
     it('should use getFormState if provided', () => {

diff --git a/src/selectors/__tests__/getFormSubmitErrors.spec.js b/src/selectors/__tests__/getFormSubmitErrors.spec.js
@@ -38,7 +38,7 @@ const describeGetFormSubmitErrors = (name, structure, setup) => {
       })
     })
 
-    it('should return undefined if there are no submitErrors', () => {
+    it('should return object if there are no submitErrors', () => {
       expect(
         getFormSubmitErrors('foo')(
           fromJS({
@@ -47,7 +47,7 @@ const describeGetFormSubmitErrors = (name, structure, setup) => {
             }
           })
         )
-      ).toEqual(undefined)
+      ).toEqual(fromJS({}))
     })
 
     it('should use getFormState if provided', () => {

diff --git a/src/selectors/__tests__/getFormSyncErrors.spec.js b/src/selectors/__tests__/getFormSyncErrors.spec.js
@@ -38,7 +38,7 @@ const describeGetFormSyncErrors = (name, structure, setup) => {
       })
     })
 
-    it('should return undefined if there are no syncErrors', () => {
+    it('should return object if there are no syncErrors', () => {
       expect(
         getFormSyncErrors('foo')(
           fromJS({
@@ -47,7 +47,7 @@ const describeGetFormSyncErrors = (name, structure, setup) => {
             }
           })
         )
-      ).toEqual(undefined)
+      ).toEqual(fromJS({}))
     })
 
     it('should use getFormState if provided', () => {

diff --git a/src/selectors/__tests__/getFormSyncWarnings.spec.js b/src/selectors/__tests__/getFormSyncWarnings.spec.js
@@ -38,7 +38,7 @@ const describeGetFormSyncErrors = (name, structure, setup) => {
       })
     })
 
-    it('should return undefined if there are no syncWarnings', () => {
+    it('should return object if there are no syncWarnings', () => {
       expect(
         getFormSyncWarnings('foo')(
           fromJS({
@@ -47,7 +47,7 @@ const describeGetFormSyncErrors = (name, structure, setup) => {
             }
           })
         )
-      ).toEqual(undefined)
+      ).toEqual(fromJS({}))
     })
 
     it('should use getFormState if provided', () => {

diff --git a/src/selectors/getFormMeta.js b/src/selectors/getFormMeta.js
@@ -2,13 +2,13 @@
 import type { Structure, GetFormState } from '../types'
 import type { GetFormMetaInterface } from './getFormMeta.types'
 
-const createGetFormMeta = ({ getIn }: Structure<*, *>) => (
+const createGetFormMeta = ({ getIn, empty }: Structure<*, *>) => (
   form: string,
   getFormState: ?GetFormState
 ): GetFormMetaInterface => (state: any) => {
   const nonNullGetFormState: GetFormState =
     getFormState || (state => getIn(state, 'form'))
-  return getIn(nonNullGetFormState(state), `${form}.fields`)
+  return getIn(nonNullGetFormState(state), `${form}.fields`) || empty
 }
 
 export default createGetFormMeta
diff --git a/src/selectors/getFormSubmitErrors.js b/src/selectors/getFormSubmitErrors.js
@@ -2,13 +2,13 @@
 import type { Structure, GetFormState } from '../types'
 import type { GetFormSubmitErrorsInterface } from './getFormSubmitErrors.types'
 
-const createGetFormSubmitErrors = ({ getIn }: Structure<*, *>) => (
+const createGetFormSubmitErrors = ({ getIn, empty }: Structure<*, *>) => (
   form: string,
   getFormState: ?GetFormState
 ): GetFormSubmitErrorsInterface => (state: any) => {
   const nonNullGetFormState: GetFormState =
     getFormState || (state => getIn(state, 'form'))
-  return getIn(nonNullGetFormState(state), `${form}.submitErrors`)
+  return getIn(nonNullGetFormState(state), `${form}.submitErrors`) || empty
 }
 
 export default createGetFormSubmitErrors
diff --git a/src/selectors/getFormSyncErrors.js b/src/selectors/getFormSyncErrors.js
@@ -2,13 +2,13 @@
 import type { Structure, GetFormState } from '../types'
 import type { GetFormSyncErrorsInterface } from './getFormSyncErrors.types'
 
-const createGetFormSyncErrors = ({ getIn }: Structure<*, *>) => (
+const createGetFormSyncErrors = ({ getIn, empty }: Structure<*, *>) => (
   form: string,
   getFormState: ?GetFormState
 ): GetFormSyncErrorsInterface => (state: any) => {
   const nonNullGetFormState: GetFormState =
     getFormState || (state => getIn(state, 'form'))
-  return getIn(nonNullGetFormState(state), `${form}.syncErrors`)
+  return getIn(nonNullGetFormState(state), `${form}.syncErrors`) || empty
 }
 
 export default createGetFormSyncErrors
diff --git a/src/selectors/getFormSyncWarnings.js b/src/selectors/getFormSyncWarnings.js
@@ -2,13 +2,13 @@
 import type { Structure, GetFormState } from '../types'
 import type { GetFormSyncWarningsInterface } from './getFormSyncWarnings.types'
 
-const createGetFormSyncWarnings = ({ getIn }: Structure<*, *>) => (
+const createGetFormSyncWarnings = ({ getIn, empty }: Structure<*, *>) => (
   form: string,
   getFormState: ?GetFormState
 ): GetFormSyncWarningsInterface => (state: any) => {
   const nonNullGetFormState: GetFormState =
     getFormState || (state => getIn(state, 'form'))
-  return getIn(nonNullGetFormState(state), `${form}.syncWarnings`)
+  return getIn(nonNullGetFormState(state), `${form}.syncWarnings`) || empty
 }
 
 export default createGetFormSyncWarnings