-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve dirty handling for check-boxes (#1762)
`dirty(undefined, false)` should be `false`. It was `true`. Intuitively, clicking twice on a check-box should return it to pristine, which is false atm (unless the checkbox is initialized with `false`). Same behavior as empty and undefined for a string. Also decreases code complexity. If both value and initial are falsey, return �equal true�. Comes with tests, both immutable and plain structures are covered. I�d call it a safe merge and would be very pleased to see it shipped. :hatching_chick:
- Loading branch information
Showing
4 changed files
with
29 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters