Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit handler / hasErrors validation bug #159

Closed
willmcclellan opened this issue Oct 22, 2015 · 2 comments
Closed

Submit handler / hasErrors validation bug #159

willmcclellan opened this issue Oct 22, 2015 · 2 comments

Comments

@willmcclellan
Copy link
Contributor

I think a bug was introduced in 1ad1a71 in relation to #156 and the hasErrors function here https://github.com/erikras/redux-form/blob/1ad1a71b1e0a9da6c218b28a52f3700960cce73f/src/createReduxForm.js#L27

My submitHandler was not triggering at all, so after tracing the code to find where it stopped I ended up here: https://github.com/erikras/redux-form/blob/1ad1a71b1e0a9da6c218b28a52f3700960cce73f/src/createReduxForm.js#L246

For me syncErrors is an empty object {} which suggests no errors, but the hasErrors function returns true for it, where I assume it should return false?

Reverting to 2.4.2 fixes the issue

erikras added a commit that referenced this issue Oct 22, 2015
Fix issue where empty err object fails validation. Fixes #159.
@erikras
Copy link
Member

erikras commented Oct 22, 2015

Fix released in v2.4.5.

@lock
Copy link

lock bot commented Jun 3, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants