Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoisting static assets #2626

Closed
samcorcos opened this issue Feb 23, 2017 · 7 comments · Fixed by #3458
Closed

Hoisting static assets #2626

samcorcos opened this issue Feb 23, 2017 · 7 comments · Fixed by #3458
Labels

Comments

@samcorcos
Copy link

Are you submitting a bug report or a feature request?

Bug report

What is the current behavior?

As far as I can tell, redux-form is not hoisting static assets.

What is the expected behavior?

I would expect it to hoist static assets.

What's your environment?

redux-form: 6.4.3
node: 7.5.0
react-native: 0.41.0
redux: 3.6.0
react-redux: 4.4.6

Other informations

I first thought this was a problem with react-navigation and I opened an issue ticket there:

react-navigation/react-navigation#332 (comment)

They said that it was an issue with redux-form, so I'm posting it here. I'm not sure how to diagnose this problem, but I'm happy to submit a PR if given some guidance.

@gustavohenke
Copy link
Collaborator

gustavohenke commented Feb 25, 2017

Yup.
reduxForm creates the following hierarchy of components:
ReduxForm -> ConnectedForm -> Form -> YourWrappedForm

The only place where hoisting happens is from Form to ConnectedForm - why?
Should be easily fixable.

@Kerumen
Copy link

Kerumen commented Mar 25, 2017

ping @erikras

@edward-s
Copy link

im having the same issue.
any fixes?

@gustavohenke
Copy link
Collaborator

PRs are welcome.

@valerybugakov
Copy link
Contributor

Bumped into the same issue ^

@erikras
Copy link
Member

erikras commented Oct 6, 2017

Published fix in v7.1.0.

@lock
Copy link

lock bot commented Oct 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants