Hoist static fields of the Wrapped Component #3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3458 +/- ##
======================================
Coverage 100% 100%
======================================
Files 68 68
Lines 1531 1531
======================================
Hits 1531 1531
Continue to review full report at Codecov.
|
gustavohenke
approved these changes
Sep 26, 2017
|
@gustavohenke anything else is required for merge? |
|
I don't think so. Code changes are handled by @erikras. |
|
How the heck did that break? I thought we were always hoisting statics. |
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty small fix for #2626 and #2230
Fixes #2626, fixes #2230