Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow: initialize function call. Called with too few arguments #3668

Closed
aij opened this issue Dec 6, 2017 · 2 comments
Closed

Flow: initialize function call. Called with too few arguments #3668

aij opened this issue Dec 6, 2017 · 2 comments
Labels

Comments

@aij
Copy link
Contributor

aij commented Dec 6, 2017

Bug

The type declaration for the initialize action creator is inconsistent with the documentation. In particular, note that the documentation makes the keepDirty and options arguments optional whereas the type declaration makes all 4 arguments required.

I will be happy to submit a PR, but just wanted to check that the documentation is considered canonical and the type should be updated to match, right?

What is the current behavior?

 59:   dispatch(initialize('feePurchase', { ...defaults, fees }));
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function call. Called with too few arguments
         v
  150:   (
  151:     form: string,
  152:     values: Object,
  ...:
  155:   ): InitializeAction
         ------------------^ function type expects more arguments. See: node_modules/redux-form/lib/actions.types.js.flow:150


What is the expected behavior?

No errors!

What's your environment?

redux-form: 7.1.2 (the type definition has not yet changed in master)
flow: 0.59.0

Other information

#3444 might be related.

aij added a commit to aij/redux-form that referenced this issue Mar 8, 2018
erikras pushed a commit that referenced this issue Mar 9, 2018
@erikras
Copy link
Member

erikras commented Jun 12, 2018

Fix released in v7.4.0.

@lock
Copy link

lock bot commented Jun 12, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants