Redux form doesn't handle recursive structures as props to Field component due to deepEqual

[itsuryev]

Hello,

I've encountered an issue with deepEqual inside of ConnectedField shouldComponentUpdate call.
Code in question:

        ...
        nextPropsKeys.some(prop => {
          return (
            !~propsToNotUpdateFor.indexOf(prop) &&
            !deepEqual(this.props[prop], nextProps[prop])
          )
        })

In my case one of the props is immutable recursive structure which makes this check run in circles.
To handle this on form level we have immutableProps:

immutableProps : Array<String> [optional]
Prop names that only require strict-equals, not deep equals, to determine shouldComponentUpdate. Useful for performance and compatibility with 3rd party immutable libraries. Defaults to [].

But somehow they are not applied on Field level.

Thank you!

[itsuryev]

Hello!

Can we please start the ball rolling on this one, at least the discussion.

In the linked pull request (#3849) I've added immutableProps option to Field component, test that everything fails without it and updated documentation to list new option.
What else should be done?

Thank you!

I humbly summon you, mighty @erikras

[erikras]

Fix released in v7.4.0.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.