Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply reduxForm immutableProps to Fields as well #3812

Closed

Conversation

itsuryev
Copy link
Contributor

@itsuryev itsuryev commented Feb 3, 2018

Suggestion for #3810

@codecov-io
Copy link

codecov-io commented Feb 3, 2018

Codecov Report

Merging #3812 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3812      +/-   ##
==========================================
- Coverage     100%   99.93%   -0.07%     
==========================================
  Files          70       70              
  Lines        1601     1610       +9     
==========================================
+ Hits         1601     1609       +8     
- Misses          0        1       +1
Impacted Files Coverage Δ
src/ConnectedFields.js 100% <100%> (ø) ⬆️
src/ConnectedField.js 99.03% <100%> (-0.97%) ⬇️
src/createReduxForm.js 100% <100%> (ø) ⬆️
src/ConnectedFieldArray.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ab6d9...9b84ff9. Read the comment docs.

@itsuryev
Copy link
Contributor Author

Closing this pull request in favor of different solution: immutableProps option directly on Field level. It would remove inconsistency when Field behave differently under two forms (one have defined imuutableProps for field, other - didn't).
Will open different pull request once new solution is ready.

@itsuryev itsuryev closed this Feb 19, 2018
@itsuryev itsuryev deleted the immutable-props-for-fields branch February 19, 2018 14:59
@lock
Copy link

lock bot commented Jun 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants