fix(readField): Generate correct prefix when reading inside array fields, fixes #1090 #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 97.28%@@ master #1091 diff @@
==========================================
Files 72 72
Lines 4081 4085 +4
Methods 757 757
Messages 0 0
Branches 312 312
==========================================
+ Hits 3970 3974 +4
Misses 111 111
Partials 0 0
|
|
LGTM |
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1090
The issue was that the prefix passed to
readFieldwasn't being generated like it is for object fields. e.g. incorrect:proposals[0].meta.items[].correct:proposals[].meta.items[].That is,
pathToHeremay actually contain indices for deeply nested stuff so you cannot use it.