Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added normalize prop to Field #1115

Merged
merged 2 commits into from
Jun 7, 2016
Merged

Added normalize prop to Field #1115

merged 2 commits into from
Jun 7, 2016

Conversation

erikras
Copy link
Member

@erikras erikras commented Jun 7, 2016

This accomplishes most of what the v5 reducer.normalize() API was providing.

@erikras erikras added the enhancement improvements in current API label Jun 7, 2016
@erikras erikras added this to the next-6.0.0 milestone Jun 7, 2016
@erikras erikras merged commit a55c024 into v6 Jun 7, 2016
@erikras
Copy link
Member Author

erikras commented Jun 8, 2016

@ooflorent Opinions on this?

@ooflorent
Copy link
Contributor

I always disliked how normalization works until this patch.
Moving this to Field was the right move.

👍 on removing getters! I think you forgot to update the Instance API documentation.

@erikras
Copy link
Member Author

erikras commented Jun 8, 2016

Great.

I think you forgot to update the Instance API documentation.

I don't think so. I only removed getters on ConnectedField, not on Field, which is what the docs address.

@ooflorent
Copy link
Contributor

Oh my bad.

@erikras erikras mentioned this pull request Jun 8, 2016
Closed
@erikras erikras deleted the normalizing branch June 8, 2016 18:01
@erikras
Copy link
Member Author

erikras commented Jul 1, 2016

Published as v6.0.0-rc.1.

@lock
Copy link

lock bot commented Jun 2, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement improvements in current API
Projects
None yet
Milestone
next-6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@erikras @ooflorent