fix(type=number): Don't parseFloat empty value strings, they NaN

[jayphelps]

#1100 added automatic number parsing of <input type="number"> fields but if the field is empty it currently applies parseFloat to an empty string, which produces NaN which could be argued either way as right or wrong, but this has the consequence of making the <input> warn in Google Chrome with:

The specified value "NaN" is not a valid number. The value must match to the following regular expression: -?(\d+|\d+.\d+|.\d+)([eE][-+]?\d+)?

This happens on every re-render, once that field has been touched. Using undefined also invokes the warning, the only thing that doesn't is the default empty string or a string that is a valid number.

Because of #1089 I can't create a JSBin to reproduce, but here's some code:

console.clear();

const { createStore, combineReducers } = Redux;
const { Provider } = ReactRedux;
const { reduxForm, Field, reducer: form } = ReduxForm;

/////////////////////////////////////////////////

const Form = reduxForm({
  form: 'example-form'
})(
  () =>
    <div>
      <Field name="count" type="number" component="input" />
    </div>
);

/////////////////////////////////////////////////


const store = createStore(
  combineReducers({ form })
);


ReactDOM.render(
  <Provider store={store}>
    <Form />
  </Provider>,
  document.getElementById('app')
);

If it's too awkward now the value might be an empty string or a parsed number, I think removing the parsing number behavior altogether is probably the right call. Then the behavior is the same as the browser. Especially because parseFloat has known quirks that may causes issues in browsers that don't actually restrict you from typing non-number characters in the input (like Chrome does). e.g. they type '1-dal@41' and parseFloat('1-dal@41') === 1

[erikras]

Published in v6.0.0-rc.1.

[antoinerousseau]

It also happens to me when I use a decimal separator that is accepted by Chrome but is not valid JS, e.g. if I try to type 12.3 with a French locale, since the separator should be ., the fields empties when I type . and I get the same alert than you.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.