Added nextState to Field/FieldArray shouldComponentUpdate #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Darmody, how's this? |
|
Why is the implementation of |
|
No good reason. I'll sync them. |
linting added comment explaining why getSyncError is different for Field and FieldArray
|
This is me using git. 🙈
I was trying to squash commits and made a mess of things. |
I was wrong. There is a good reason, and I have documented it with a comment. |
|
Hmm, @erikras, LGTM. I will try it in my project, and give you my feedback. |
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
shouldComponentUpdateneeds bothnextStateandnextContextto know whether or not it needs to update. IgnoringnextStatewas previously causing issues withshallowCompare, becausethis.statewasnullandnextStatewasundefined(not passed).The sync error also needs to be pulled from
nextContextto know whether or not it needs to update.This was originally raised in #1141.
@ooflorent, please review. (ignore the test in
FieldArray.spec.js)