Always return rejected promise when submit is rejected #1203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I never liked |
|
Published in |
| @@ -223,7 +223,10 @@ const createReduxForm = | |||
| return promise | |||
| } | |||
| this.submitPromise = promise | |||
| return promise.then(this.submitCompleted, this.submitCompleted) | |||
| return promise.then(this.submitCompleted, err => { | |||
There was a problem hiding this comment.
As reported in #1266, this line throws undefined:1 Uncaught (in promise) Object { ...errors } if there are validation errors.
If I do this
return promise.then(this.submitCompleted, err => {
this.submitCompleted()
return Promise.reject(err)
}).catch(err => {
console.log('==> CATCH', err)
})
the error is caught. Let's continue discussion in #1266
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1201.
Also removed
returnRejectedSubmitPromise. That was put in as a stopgap measure to avoid a breaking change, but I think the promise that is returned from submitting should always be rejected if there was an error.@ooflorent, please review.