Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to access the wrapped component from reduxForm HoC #1224

Merged
merged 15 commits into from
Sep 2, 2016

Conversation

milkersarac
Copy link

No description provided.

@@ -49,8 +49,6 @@
* [6.0.0-alpha.10](http://redux-form.com/6.0.0-alpha.10/)
* [6.0.0-alpha.11](http://redux-form.com/6.0.0-alpha.11/)
* [6.0.0-alpha.13](http://redux-form.com/6.0.0-alpha.13/)
* [6.0.0-alpha.14](http://redux-form.com/6.0.0-alpha.14/)
* [6.0.0-alpha.15](http://redux-form.com/6.0.0-alpha.15/)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert these changes

@ooflorent
Copy link
Contributor

ooflorent commented Jun 28, 2016

Thanks for you contribution. The overall logic seems good to me. However:

  • Could you revert the changes made to README.md and package.json?
  • Could you run npm run lint -- --fix and fix the remaining errors?
  • Could you add tests to getWrappedInstance()?

@ooflorent ooflorent changed the title higer order components implmentation to reach reduxForm from modal. Add a way to access the wrapped component from reduxForm HoC Jun 28, 2016
@milkersarac
Copy link
Author

Thank you for your advice. I tried to correct it as you like. Best.

@ooflorent
Copy link
Contributor

ooflorent commented Jun 28, 2016

Build doesn't pass. Could you fix the linting?

@milkersarac
Copy link
Author

Ok, I am on it. I will also commit the tests for getWrappedInstance().

@codecov-io
Copy link

codecov-io commented Jul 14, 2016

Current coverage is 96.90% (diff: 100%)

Merging #1224 into master will decrease coverage by 0.21%

@@             master      #1224   diff @@
==========================================
  Files            73         73          
  Lines          4123       4197    +74   
  Methods         770        772     +2   
  Messages          0          0          
  Branches        316        324     +8   
==========================================
+ Hits           4004       4067    +63   
- Misses          119        130    +11   
  Partials          0          0          

Powered by Codecov. Last update 636ea87...439c1f5

@lbdremy
Copy link

lbdremy commented Jul 20, 2016

Nice addition I actually need this, how can I help to get this merge into the next release ?

@milkersarac
Copy link
Author

Hey, thank you. I am having trouble to pass the codecov out of tests.

@milkersarac
Copy link
Author

Hey @ooflorent, could you give some hints about how to pass tests while not losing from codecov?

@erikras erikras changed the base branch from master to v5 September 2, 2016 06:38
@erikras erikras merged commit df939dc into redux-form:v5 Sep 2, 2016
@erikras
Copy link
Member

erikras commented Jan 6, 2017

Published in v5.3.4.

@lock
Copy link

lock bot commented Jun 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants