-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to access the wrapped component from reduxForm
HoC
#1224
Conversation
@@ -49,8 +49,6 @@ | |||
* [6.0.0-alpha.10](http://redux-form.com/6.0.0-alpha.10/) | |||
* [6.0.0-alpha.11](http://redux-form.com/6.0.0-alpha.11/) | |||
* [6.0.0-alpha.13](http://redux-form.com/6.0.0-alpha.13/) | |||
* [6.0.0-alpha.14](http://redux-form.com/6.0.0-alpha.14/) | |||
* [6.0.0-alpha.15](http://redux-form.com/6.0.0-alpha.15/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert these changes
Thanks for you contribution. The overall logic seems good to me. However:
|
reduxForm
HoC
Thank you for your advice. I tried to correct it as you like. Best. |
Build doesn't pass. Could you fix the linting? |
Ok, I am on it. I will also commit the tests for |
Current coverage is 96.90% (diff: 100%)@@ master #1224 diff @@
==========================================
Files 73 73
Lines 4123 4197 +74
Methods 770 772 +2
Messages 0 0
Branches 316 324 +8
==========================================
+ Hits 4004 4067 +63
- Misses 119 130 +11
Partials 0 0
|
Nice addition I actually need this, how can I help to get this merge into the next release ? |
Hey, thank you. I am having trouble to pass the codecov out of tests. |
Hey @ooflorent, could you give some hints about how to pass tests while not losing from codecov? |
Published in |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
No description provided.