Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When there are no registered fields, return an empty list rather than… #1254

Closed
wants to merge 1 commit into from

Conversation

clayne11
Copy link
Contributor

@clayne11 clayne11 commented Jul 1, 2016

… trying to map over nothing

Fixes #1231

@ooflorent
Copy link
Contributor

ooflorent commented Jul 1, 2016

I think this change should be made into the store to ensure that registeredFields is always an array.
Iterating over it would have no cost. What do you think? Otherwise, it looks good to me.

@erikras
Copy link
Member

erikras commented Jul 1, 2016

I fixed this already. I'll add the test, though.

erikras added a commit that referenced this pull request Jul 1, 2016
@erikras erikras closed this Jul 1, 2016
@ruiaraujo
Copy link
Contributor

A release with that fix would be awesome, I am seeing some crashes in production related to registeredFields being undefined.

@erikras
Copy link
Member

erikras commented Jul 1, 2016

Published in v6.0.0-rc.1.

@clayne11 clayne11 deleted the submit-no-fields branch July 1, 2016 18:14
@lock
Copy link

lock bot commented Jun 2, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants