Create a initial form state before creating fields #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yesmeck
force-pushed
the
fix-initial-values
branch
2 times, most recently
from
9829afc
to
2ae07f2
Compare
Current coverage is 97.12%@@ master #1259 diff @@
==========================================
Files 73 74 +1
Lines 4121 4140 +19
Methods 769 771 +2
Messages 0 0
Branches 315 317 +2
==========================================
+ Hits 4002 4021 +19
Misses 119 119
Partials 0 0
|
This should fix the long living bug redux-form#621. First round =========== My first try was redux-form#1025, I tried pass a default field state to [updateField](https://github.com/erikras/redux-form/blob/v5.3.1/src/updateField.js#L8) so that updateField can read initial value from given state. But I forgot the the validate function which causes validate function cann't read initial values at first render. Second round ============ My second try was redux-form#1061, I tried pass initial values to validate function. But I forgot a form may have no initial values or only have partial initial values which causes redux-form#1241. Third round ===================== I thought I can create a initial form state before creating fields, so that updateField and validate function can both read initial values. Hope this is the last round.
yesmeck
force-pushed
the
fix-initial-values
branch
from
2ae07f2
to
0abc5e7
Compare
|
@erikras Could you create a |
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the long living bug #621.
First round
My first try was #1025, I tried pass a default field state to updateField so that updateField can read initial value from given state.
But I forgot the the validate function which causes validate function cann't read initial values at first render.
Second round
My second try was #1061, I tried pass initial values to validate function. But I forgot a form may have no initial values or only have partial initial values which causes #1241.
Third round
I thought I can create a initial form state before creating fields, so that updateField and validate function can both read initial values.