Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @@ infront of action names #2110

Merged
merged 1 commit into from
Nov 11, 2016

Conversation

liamhubers
Copy link
Contributor

Following the convention of adding @@ in front of action names

@codecov-io
Copy link

codecov-io commented Nov 10, 2016

Current coverage is 100% (diff: 100%)

Merging #2110 into master will not change coverage

@@           master   #2110   diff @@
=====================================
  Files          58      58          
  Lines        1134    1134          
  Methods         0       0          
  Messages        0       0          
  Branches        0       0          
=====================================
  Hits         1134    1134          
  Misses          0       0          
  Partials        0       0          

Powered by Codecov. Last update d6bec04...250119f

@DanielRuf
Copy link

@liamhubers can you point me to the convention? At least I find nothing about it http://redux.js.org/docs/basics/Actions.html

@liamhubers
Copy link
Contributor Author

liamhubers commented Nov 11, 2016

I had a look and can't find it written anywhere, but people seem to be doing it anyway:
https://github.com/reactjs/redux/blob/master/src/createStore.js#L11
https://github.com/reactjs/react-router-redux/blob/a304bda820ba57f68961035eff1950e618047b81/src/reducer.js#L5

It's convenient for me because I need to filter out all third-party redux actions

@DanielRuf
Copy link

DanielRuf commented Nov 11, 2016

Ah ok. Yes, saw it when I printed the triggered actions and then saw the double @. Good to know 👍

@erikras
Copy link
Member

erikras commented Nov 11, 2016

This could be a breaking change if anyone was dumb enough (or just n00b enough) to listen for one of these actions via an action.type === 'stringvalue'.

@erikras erikras merged commit 303a026 into redux-form:master Nov 11, 2016
@erikras
Copy link
Member

erikras commented Nov 30, 2016

Published in v6.2.1.

@lock
Copy link

lock bot commented Jun 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants