Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove meta.touched prop from FieldArray #2836

Merged
merged 1 commit into from
Apr 20, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/fieldArrays/src/FieldArraysForm.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@ const renderHobbies = ({ fields, meta: { error } }) => (
</ul>
)

const renderMembers = ({ fields, meta: { touched, error, submitFailed } }) => (
const renderMembers = ({ fields, meta: { error, submitFailed } }) => (
<ul>
<li>
<button type="button" onClick={() => fields.push({})}>Add Member</button>
{(touched || submitFailed) && error && <span>{error}</span>}
{submitFailed && error && <span>{error}</span>}
</li>
{fields.map((member, index) =>
<li key={index}>
Expand Down
20 changes: 0 additions & 20 deletions src/__tests__/FieldArray.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,26 +110,6 @@ const describeFieldArray = (name, structure, combineReducers, expect) => {
expect(props.meta.form).toBe('testForm')
})

it('should get touched from Redux state', () => {
const props1 = testProps({
values: {
foo: 'bar'
}
})
expect(props1.meta.touched).toBe(false)
const props2 = testProps({
values: {
foo: 'bar'
},
fields: {
foo: {
touched: true
}
}
})
expect(props2.meta.touched).toBe(true)
})

it('should not pass api props into custom', () => {
const store = makeStore()
const renderSpy = createSpy()
Expand Down
1 change: 0 additions & 1 deletion src/createFieldArrayProps.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ const createFieldArrayProps = (getIn, name, form, sectionPrefix, getValue,
pristine,
submitting,
submitFailed,
touched: !!(state && getIn(state, 'touched')),
valid: !error
},
...props,
Expand Down