Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added syncErrors to reset reducer #2847

Closed
wants to merge 1 commit into from

Conversation

VdeVentura
Copy link

Fixing issue #2838

Validations were not triggered after reset

@codecov-io
Copy link

Codecov Report

Merging #2847 into master will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2847      +/-   ##
==========================================
- Coverage     100%   99.92%   -0.08%     
==========================================
  Files          67       67              
  Lines        1395     1398       +3     
==========================================
+ Hits         1395     1397       +2     
- Misses          0        1       +1
Impacted Files Coverage Δ
src/reducer.js 99.6% <66.66%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48f1781...8850d8a. Read the comment docs.

@erikras
Copy link
Member

erikras commented May 4, 2017

I don't think this is the solution. You don't want to just persist the previous sync errors, as RESET has most likely changed the values, so the sync errors might be wrong.

@erikras erikras closed this May 4, 2017
@lock
Copy link

lock bot commented Jun 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants