-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add active prop to reduxForm #2856
Conversation
Adding new prop passing to form via reduxForm. The value shows up when any field is active, but it is not passing to form at all. The prop, for example, helps doing more ux stuff like showing form as a modal when user is interacting withing the form and so on. Hope this proposal is worthy for you as well.
Codecov Report
@@ Coverage Diff @@
## master #2856 +/- ##
======================================
Coverage 100% 100%
======================================
Files 67 67
Lines 1395 1396 +1
======================================
+ Hits 1395 1396 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but a prop saying the name of the active field would probably be more useful than this one.
You are right, I'm gonna update it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thoughts, @erikras?
Pro: definitely seems useful When you tab from input |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Adding new prop passing to form via reduxForm. The value shows up when any field is active, but it is not passing to form at all. The prop, for example, helps doing more ux stuff like showing form as a modal when user is interacting withing the form and so on. Hope this proposal is worthy for you as well.