formValues: add decorator #3011
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3011 +/- ##
======================================
Coverage 100% 100%
======================================
Files 67 68 +1
Lines 1410 1433 +23
======================================
+ Hits 1410 1433 +23
Continue to review full report at Codecov.
|
|
Updated with more tests. |
|
Looks good. Can you write the docs for this? |
src/immutable/formValues.js
Outdated
| @@ -0,0 +1,4 @@ | |||
| import createValues from '../createValues' | |||
There was a problem hiding this comment.
Should this not be '../createFormValues'?
There was a problem hiding this comment.
Wow! How do the tests even pass? 😕
There was a problem hiding this comment.
ah yes the tests create their own. Not ideal…
|
Where do I go for writing docs? |
You can either use `formValues(path1, path2, ...)` or `formValues({prop1: path1, prop2: path2, ...})` to get values from the current form as props.
|
@erikras Alright, it's now testing the actually created |
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
You can either use
formValues(path1, path2, ...)orformValues({prop1: path1, prop2: path2, ...})to get values from the current form as props.Implements #2996