Do not clear errors unless field is being removed from the form #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests asserts that error should only be cleared when unregistering is causing the field to be removed, not when its just decrementing the count.
Codecov Report
@@ Coverage Diff @@
## master #3064 +/- ##
======================================
Coverage 100% 100%
======================================
Files 68 68
Lines 1452 1451 -1
======================================
- Hits 1452 1451 -1
Continue to review full report at Codecov.
|
gustavohenke
approved these changes
Jun 15, 2017
|
Thanks! |
|
Excellent work. Man, I really ❤️ CodeSandbox. It was so easy for you to clearly demonstrate this bug. |
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently errors will be cleared every time an
UNREGISTERaction is fired even if the count is greater than 1.This would cause the errors to get cleared even when there is still a form field on the page.
you can see a demo of the error here
This PR changes the behavior so that errors will only be cleared if the count is <= 0 and the field is actually being removed from the
registeredFields