Handle changes to Field validate/warn props #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will ensure that changes to these functions are reflected in form validation. Achieved by re-registing the Field with reduxForm when new validate or warn props are recieved. See issue: redux-form#3012
Codecov Report
@@ Coverage Diff @@
## master #3094 +/- ##
======================================
Coverage 100% 100%
======================================
Files 68 68
Lines 1449 1451 +2
======================================
+ Hits 1449 1451 +2
Continue to review full report at Codecov.
|
|
Published in |
This was referenced Jul 21, 2017
erikras
pushed a commit
that referenced
this pull request
Jul 31, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure that changes to these functions are reflected in form
validation. Achieved by re-registing the Field with reduxForm when new
validate or warn props are recieved.
See issue: #3012