Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name parameter for field level validator #3364

Merged

Conversation

Misiur
Copy link
Contributor

@Misiur Misiur commented Aug 29, 2017

See #3350

@codecov-io
Copy link

codecov-io commented Aug 29, 2017

Codecov Report

Merging #3364 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3364   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          68      68           
  Lines        1522    1522           
======================================
  Hits         1522    1522
Impacted Files Coverage Δ
src/generateValidator.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a9c7e...16d750e. Read the comment docs.

Copy link
Collaborator

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for this feature.

@erikras
Copy link
Member

erikras commented Aug 31, 2017

Can you update the docs, too?

@Misiur
Copy link
Contributor Author

Misiur commented Aug 31, 2017

There you go

@erikras
Copy link
Member

erikras commented Oct 6, 2017

Published in v7.1.0.

@lock
Copy link

lock bot commented Jun 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants