Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include previous form values to onChange handler #3530

Merged
merged 3 commits into from
Oct 23, 2017

Conversation

ericbiewener
Copy link
Contributor

It would be useful to know which field has changed in the onChange handler. Rather than bothering to compute this itself, redux-form can just send along the previous form values as an additional argument to the onChange handler.

One use case for this is an onChange handler that auto-submits the form values when one has changed.

@codecov-io
Copy link

codecov-io commented Oct 16, 2017

Codecov Report

Merging #3530 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3530   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          70      70           
  Lines        1540    1540           
======================================
  Hits         1540    1540
Impacted Files Coverage Δ
src/createReduxForm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 347513a...b6c7182. Read the comment docs.

@erikras
Copy link
Member

erikras commented Oct 17, 2017

Update the docs, please.

Copy link
Collaborator

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the docs and this test

@ericbiewener
Copy link
Contributor Author

Ok, docs & test have been updated.

@erikras erikras merged commit 4e9d101 into redux-form:master Oct 23, 2017
@erikras
Copy link
Member

erikras commented Oct 25, 2017

Published in v7.1.2.

@lock
Copy link

lock bot commented Jun 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants