move initialization to componentDidMount

[brucewpaul]

React 16 ensures a certain order of lifcecycles when replacing a
component which causes redux-form to destroy the form, breaking
it. This change, when used with enableReinitialize, causes the
form to reinitialize correctly, preserving the form.

this pr address #3435

this is probably going to fail a lot of tests, but want to start the
conversation as to what is needed for redux-form to work with
React 16

[brucewpaul]

cc @erikras @gustavohenke

[brucewpaul]

actually, just copying the same functionality form componentWIllMount to componentDidMount passes all the test and is working in our app. Although this solution of course comes with the added perf costs which isn't ideal at all...

[gustavohenke]

Well, actually, quite a few tests are breaking!
https://travis-ci.org/erikras/redux-form/jobs/302635057#L6766

[brucewpaul]

:) @gustavohenke this pr doesn't include the most recent note I wrote. Locally, all the tests are passing. I will update this pr to be that version since all the tests pass

[brucewpaul]

@gustavohenke updated and the tests just passed locally

[codecov-io]

Codecov Report

Merging #3615 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3615   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          70      70           
  Lines        1558    1563    +5     
======================================
+ Hits         1558    1563    +5

Impacted Files	Coverage Δ
src/createReduxForm.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df718b8...74e31ed. Read the comment docs.

[codecov-io]

Codecov Report

Merging #3615 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3615   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          70      70           
  Lines        1558    1563    +5     
======================================
+ Hits         1558    1563    +5

Impacted Files	Coverage Δ
src/createReduxForm.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df718b8...74e31ed. Read the comment docs.

[stevenmusumeche]

is it likely that this PR will be merged? I have a workaround using setTimeout that I'd rather not implement if I don't have to.

[brucewpaul]

@stevenmusumeche could you give an example of the workaround?

[stevenmusumeche]

In my case, I am navigating AWAY from the form, and when I go back to it, it already has "submitSucceeded" set to true from the previous submission. So, I was able to do a setTimeout and call destroy on the form after 1 second. Dirty hack, but it works for my use case.

[brucewpaul]

@stevenmusumeche does this solution work for you?

[stevenmusumeche]

This PR? I have not run my code with it, sorry.

[erikras]

Sorry guys. I was sick last week.

Meh, I don't care about "perf costs" when hot reloading. Looks good.

[brucewpaul]

@erikras I was experiencing this in production, not just hot reloading, which is why I brought up the perf cost of this change.

[stevenmusumeche]

Yes, same here, it's not just a hot reloading issue.

[brucewpaul]

@erikras would you be able to do another release that includes this?

[erikras]

Published in v7.2.0.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.