Dont delete initial initialValues structure on withCleanUp #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ms88privat
changed the title
ms88privat
force-pushed
the
dont-delete-parent-if-initialised
branch
from
e7ad08a
to
e32110e
Compare
ms88privat
force-pushed
the
dont-delete-parent-if-initialised
branch
from
e32110e
to
2b26dfe
Compare
Codecov Report
@@ Coverage Diff @@
## master #3619 +/- ##
======================================
Coverage 100% 100%
======================================
Files 70 70
Lines 1558 1562 +4
======================================
+ Hits 1558 1562 +4
Continue to review full report at Codecov.
|
ms88privat
force-pushed
the
dont-delete-parent-if-initialised
branch
from
f3da938
to
c8aa688
Compare
|
@erikras Any opinion on that one? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possibly fixes #2597 #3366
@erikras What's your opinion here?
I will create an additional test to catch this case for the future.
Edit: Let me try to restructure it. I don't like to have this logic inside a util function.
Edit2: The second commit did restructure the implementation.
deleteInWithCleanUpnow takes an optionalshouldDeletefunction, where you can specify when to delete and when not.Edit3: Added a test to the
BLURreducer, if you like it, I can add it also to theCHANGEandCLEAR_FIELDSreducer.