Fix asyncValidate when asyncBlur/ChangeFields are provided #3647
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3647 +/- ##
======================================
Coverage 100% 100%
======================================
Files 70 70
Lines 1574 1577 +3
======================================
+ Hits 1574 1577 +3
Continue to review full report at Codecov.
|
|
Nicely done. |
| ~asyncBlurFields.indexOf(name.replace(/\[[0-9]+\]/g, '[]')) | ||
| const fieldNeedsValidationForChange = | ||
| asyncChangeFields && | ||
| ~asyncChangeFields.indexOf(name.replace(/\[[0-9]+\]/g, '[]')) |
There was a problem hiding this comment.
@shepmaster pointed out on a PR of mine that asyncValidate gets called in one location without any arguments, causing name.replace to throw an error. Although this code has now been modified, I expect this to still be an issue on lines 679 & 682.
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Check if either asyncBlurFields or asyncChangeFields are provided. If neither is, trigger validation. If any is, need to check if the blurred/changed field is on the corresponding list.
Fixes #3645