Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix field-level validation on previously emptied FieldArray #3697

Merged
merged 1 commit into from
Dec 22, 2017

Conversation

adamcapone
Copy link
Contributor

Empty lastFieldValidatorKeys when no field level validators were found. This allows validateIfNeeded to detect when a previously emptied FieldArray has an item added back.

@codecov-io
Copy link

codecov-io commented Dec 17, 2017

Codecov Report

Merging #3697 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3697   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          70      70           
  Lines        1577    1578    +1     
======================================
+ Hits         1577    1578    +1
Impacted Files Coverage Δ
src/createReduxForm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02b3e9...de45943. Read the comment docs.

@erikras erikras merged commit f2ae8e4 into redux-form:master Dec 22, 2017
@erikras
Copy link
Member

erikras commented Jan 18, 2018

Published in v7.2.1.

@lock
Copy link

lock bot commented Jun 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants