Log onSubmitSuccess thrown errors #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3723 +/- ##
======================================
Coverage 100% 100%
======================================
Files 70 70
Lines 1578 1582 +4
======================================
+ Hits 1578 1582 +4
Continue to review full report at Codecov.
|
|
Can you add a test that fails before your change, but passes after your change? |
|
Published in |
naw
reviewed
Feb 6, 2018
| onSubmitSuccess(submitResult, dispatch, props) | ||
| return result | ||
| .then(submitResult => { | ||
| try { |
There was a problem hiding this comment.
What is the purpose of this try block if you're just rethrowing the exception? Seems extraneous, but maybe I'm missing something.
naw
pushed a commit
to naw/redux-form
that referenced
this pull request
Feb 8, 2018
This reverts commit 1a0660c.
erikras
pushed a commit
that referenced
this pull request
Mar 2, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this issue, I added a
console.errorto get the expected behaviorIs it ok ? I have the impression that I didn't understand well the bug, cause it's normal that the error get swallowed as it's thrown in a promise