Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validation after duplicate field unmount #3756

Merged
merged 3 commits into from
Jan 16, 2018

Conversation

jedwards1211
Copy link
Contributor

fix #3688
fixed by keeping a reference count of names registered with ReduxForm.register/unregister, just like the reducer keeps a reference count of fields.

@jedwards1211 jedwards1211 changed the title fix duplicate field validation issue fix validation after duplicate field unmount Jan 15, 2018
@codecov-io
Copy link

codecov-io commented Jan 15, 2018

Codecov Report

Merging #3756 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3756   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          70      70           
  Lines        1578    1585    +7     
======================================
+ Hits         1578    1585    +7
Impacted Files Coverage Δ
src/createReduxForm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90fdd65...9649409. Read the comment docs.

@erikras erikras merged commit 3db0866 into redux-form:master Jan 16, 2018
@erikras
Copy link
Member

erikras commented Jan 18, 2018

Published in v7.2.1.

@jedwards1211
Copy link
Contributor Author

Muchas gracias!

@lock
Copy link

lock bot commented Jun 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation breaks after unmounting of a duplicated field
3 participants