Fix for double INITIALIZE happening on first mount #3797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions that happen when a form mounts
Codecov Report
@@ Coverage Diff @@
## master #3797 +/- ##
======================================
Coverage 100% 100%
======================================
Files 70 70
Lines 1593 1593
======================================
Hits 1593 1593
Continue to review full report at Codecov.
|
erikras
added a commit
that referenced
this pull request
Feb 1, 2018
…Array and Fields." (#3804) * Revert "Fix for formValues not reacting to props change (#3794)" This reverts commit 701fdc0. * Revert "Fix for double INITIALIZE happening on first mount (#3797)" This reverts commit 5c13be0. * Revert "Fixes asyncErrors and submitErrors for FieldArray and Fields components, since they were changed for Fields in #3755 (#3802)" This reverts commit 4b4e994.
|
Dammit. I accidentally reverted this. Can you submit a new copy of this PR from your fork? |
|
Nevermind. I did it myself. |
|
Published in |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for an issue where the INITIALIZE action is fired twice, clearing change actions that happen when a form mounts.
See #3690 for details of the bug.
This fixes #3706 and fixes #3690.
I attempted to remove those formatting changes, but they got reversed by the precommit hook I believe.