Immutable setIn is broken with more than 32 elements in an array.

[dagstuan]

This PR fixes an issue introduced in #3692 where the mergeLists method in setIn.js for immutable.js was updated due to mergeDeepWith being removed as a List function in immutable.js@4.0.0-rc.5. Unfortunately this change introduced and error in which arrays with more than 32 elements were behaving unexpectedly since the new way of doing it didnt use ordered maps, instead just calls toMap(), which causes the merging to lose order with more than 32 elements due to optimizations in immutable.js. After 4.0.0-rc.5, the mergeDeepWith-method is exported as a global export instead of being attatched to Map, and List. This PR uses the global export version 4.x and uses the old way of merging for users with 3.x. I also added a test with long arrays for immutable setIn.

This PR should fix #3791

@erikras @gustavohenke can this be merged fast? Its pretty important since all long FieldArrays are currently broken.

[codecov-io]

Codecov Report

Merging #3803 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3803   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          70      70           
  Lines        1593    1597    +4     
======================================
+ Hits         1593    1597    +4

Impacted Files	Coverage Δ
src/structure/immutable/setIn.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 216bffa...bfac461. Read the comment docs.

[dagstuan]

@erikras is it possible to allow the testfile for setIn to be longer than 250 lines so codeclimate will accept it? Or should I move the test to a separate file?

[erikras]

Code Climate is supposed to be ignoring *.spec.js, but their API changed.

[cristian-sima]

you are a the God. I just encored this problem and I was writing an issue :D waiting for solution

[erikras]

Published in v7.2.2.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.