Fix Immutable 4 merging. Again. #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Had to do it by hand instead of using built in methods
Codecov Report
@@ Coverage Diff @@
## master #3808 +/- ##
======================================
Coverage 100% 100%
======================================
Files 70 70
Lines 1602 1601 -1
======================================
- Hits 1602 1601 -1
Continue to review full report at Codecov.
|
…immutable 3 and 4
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the list-merging was still broken in
7.2.2since I hadnt bothered to test arrays with content in them already,immutable.js@4.0.0-rc.5+concats lists when merging them. This PR does the merging by hand instead of using a built in method to do it, and I added a test for it, so it shouldnt break in the future. I have tested this solution both withimmutable@3.8.2andimmutable@4.0.0-rc.9. Sorry for the broken PR that got merged in7.2.2.