Feat: add keepValues to initialize (closes #3649)

[JPeer264]

I added the feature of #3649. Now I added just an option keepValues, but kept the initial values with the same flag. Should another flag keepInitial be set for this?

[codecov-io]

Codecov Report

Merging #3817 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3817   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          70      70           
  Lines        1601    1609    +8     
======================================
+ Hits         1601    1609    +8

Impacted Files	Coverage Δ
src/createReducer.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ab6d9...9fe7958. Read the comment docs.

[swils]

This is a fantastic feature, and by coincidence exactly what I need right now :-) Anyone an idea on how long would it take for this be part of an official release?

[JPeer264]

@swils happy to hear. As you also have a use case for this, would you more prefer to keep the initial values and values just with one option, or separately? Maybe like keepValues and keepInitial?

Also I guess this might take some time, regarding to other PRs. My temporarily solution (as I really need this right now) would be to fork this repo, merge this branch into master and directly add my repo as dependency in my node modules 😅

[swils]

Not sure if I understand what you mean by the difference between keepValues and keepInitial? 😄

[JPeer264]

Like my PR is about keeping the values and the initials. So in the following example I have an already registered field aField.

formReducer: {
  myForm: {
	values: {
	  aField: 'some value',
    },
    initial: {
      aField: 'some initial value',
    },
  },
},

Current PR implementation
When I now initialize another field with the option { keepValues: true } it will keep both previous values and initials:

formReducer: {
  myForm: {
	values: {
	  aField: 'some value', // <- kept
      aNewField: 'new value',
    },
    initial: {
      aField: 'some initial value', // <- kept
      aNewField: 'new value',
    },
  },
},

Seperated options
So what if I don't want to preserve the old values and just keep the initials. I need separated options: { keepValues: true, keepInitial: true }:

Here with the option { keepInitial: true }

formReducer: {
  myForm: {
	values: {
	  // any old value is lost here
      aNewField: 'new value',
    },
    initial: {
      aField: 'some initial value',
      aNewField: 'new value',
    },
  },
},

Here with the option { keepValues: true }

formReducer: {
  myForm: {
	values: {
      aField: 'some value',
      aNewField: 'new value',
    },
    initial: {
	  // any old value is lost here
      aNewField: 'new value',
    },
  },
},

[erikras]

Published in v7.3.0.

[swils]

Hmmm @JPeer264 no real opinion on this, I guess more options are better in this case?

[JPeer264]

@swils ya it got merged now, so it is one option (keepValues) now.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.