Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update FlowType Definitions to include clearFields #3820

Merged
merged 1 commit into from
Mar 2, 2018
Merged

Fix: Update FlowType Definitions to include clearFields #3820

merged 1 commit into from
Mar 2, 2018

Conversation

jwineman
Copy link
Contributor

@jwineman jwineman commented Feb 6, 2018

Steps to reproduce:

  1. Install redux-form 7.2.3

  2. Install flow-bin 0.53

  3. Try to import clearFields with Flow enabled:

// @flow
import {clearFields} from 'redux-form';

Expected: Flow does not error.
Actual: Flow displays the following error:

 2: import {clearFields} from 'redux-form';
             ^^^^^^^^^^^ Named import from module `redux-form`. This module has no named export called `clearFields`.

This is because index.js.flow is missing declarations for clearFields.

This is my first time contributing to this repository - please let me know if there is anything else I need to do in order to get this PR accepted.

@codecov-io
Copy link

codecov-io commented Feb 6, 2018

Codecov Report

Merging #3820 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3820   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          70      70           
  Lines        1601    1601           
======================================
  Hits         1601    1601

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ab6d9...633d50e. Read the comment docs.

@erikras
Copy link
Member

erikras commented Mar 2, 2018

Published in v7.3.0.

@jwineman
Copy link
Contributor Author

jwineman commented Mar 2, 2018

Thanks!

@jwineman jwineman deleted the jwineman/fix-clearFields-flowtype branch March 2, 2018 19:10
@lock
Copy link

lock bot commented Jun 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants