Add the Webpack 4 'sideEffects' flag #3870
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Webpack v4 sideEffects optimization. See a similar PR for Lodash: lodash/lodash#3533
What does it do? If I import just one export from the library:
then
sideEffects: false
ensures that only the reducer code and the code it depends on will be imported, and not all the reexports ines/index.js
.If the
sideEffects
flag were not set tofalse
, Webpack must assume that the reexported modules can have side-effects (e.g., setting a property onwindow
) and imports them all.Very useful for code splitting where the main chunk typically imports only the reducer and the other chunks import UI components, selectors etc.