Use shouldError/shouldWarn by default unless only shouldValidate is passed in. #3881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing a custom
shouldError
prop, it needs to be passed into bothshouldError
and the deprecatedshouldValidate
.If only
shouldError
is passed in theshouldValidate
may override the expected behavior. For example theshouldError
prop returnsfalse
but the defaultshouldValidate
returnstrue
, the code will still run the validation.This PR will allow for either
shouldError
orshouldValidate
to be used.