Add immutableProps to HOC propTypes, do not pass it to wrapped component #3913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3913 +/- ##
======================================
Coverage 100% 100%
======================================
Files 70 70
Lines 1629 1629
======================================
Hits 1629 1629
Continue to review full report at Codecov.
|
|
Perfect. Great work! Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
immutablePropsis described in theReduxForm.mdfile, however it is not included in theConfigtype definition and is passed down to the wrapped component.I think this is not intended, so I've excluded it from passing down. This is a minor change, so I haven't opened any issue
This is my first public PR ever, so please provide feedback if I have omitted some step (btw it seems the CONTRIBUTING.md file is outdated, as e.g. there is no
formatscript in thepackage.jsonfile.)Maybe I should also add a test verifying if proper props are passed down to the
WrappedComponent?